Conversation
jif-oai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The memory read-tool surface had two implementations: the app-server extension path under
ext/memories, and an unusedcodex-memories-mcpworkspace crate undermemories/mcp. The MCP crate no longer has reverse dependents, so keeping it around preserves duplicate backend, schema, and tool code that is not part of the live app-server memory path.Dropping the orphaned crate makes the remaining memory crate split clearer:
memories/readowns read-path prompt/citation helpers,memories/writeowns the write pipeline, andext/memoriesowns the app-server extension integration.What changed
memories/mcpcrate and its Bazel/Cargo metadata.memories/mcpfrom the Rust workspace and lockfile.memories/README.mdso it only lists the remaining reusable memory crates.Verification
cargo metadata --format-version 1 --no-depssucceeds.