Skip to content

chore: move memory prompt builder into extension#24558

Merged
jif-oai merged 1 commit into
mainfrom
jif/migrate-to-extension
May 26, 2026
Merged

chore: move memory prompt builder into extension#24558
jif-oai merged 1 commit into
mainfrom
jif/migrate-to-extension

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 26, 2026

Why

The memories extension now owns the read-path developer instructions it injects at thread start. Keeping that prompt builder and template in codex-memories-read left the extension depending on a helper crate for extension-specific prompt assembly, and kept async template/truncation dependencies in the read crate after the remaining read surface no longer needed them.

What changed

  • Moved prompts.rs, its tests, and templates/memories/read_path.md from memories/read into ext/memories.
  • Wired MemoryExtension to call the local prompt builder and added the moved templates to ext/memories/BUILD.bazel compile data.
  • Removed the now-unused prompt export and prompt-related dependencies from codex-memories-read.

Testing

  • Not run locally.

@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 26, 2026

@codex review

@jif-oai jif-oai changed the title chore: migrate extension chore: move memory prompt builder into extension May 26, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit de513a8 into main May 26, 2026
30 checks passed
@jif-oai jif-oai deleted the jif/migrate-to-extension branch May 26, 2026 09:53
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant