Move memory state to a dedicated SQLite DB#24591
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4912f62b0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c415545cee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
left a comment
There was a problem hiding this comment.
Performed some basic smoke test and it worked as expected. Left one nit and one question, but none are blockers.
Approved 👍
Summary
Generated memory rows and their stage-one/stage-two job state currently live in
state_5.sqlitealongside thread metadata. That makes memory cleanup and regeneration share the main state schema even though those rows are memory-pipeline data and can be rebuilt independently from the durable thread records.This PR moves the memory-owned tables into a dedicated
memories_1.sqliteruntime database while keeping thread metadata instate_5.sqlite.Changes
state/memory_migrations.MemoryStorebehindStateRuntime::memories()and moves memory table/job operations onto that store.state/memory_migrations/0001_memories.sql.debug clear-memories, and app-servermemory/resetto operate through the memories DB.Verification
codex-statetests for deleted-thread memory visibility and already-polluted phase-two enqueue behavior.debug clear-memories, app-servermemory/reset, and memories startup tests to seed and assert memory rows throughmemories_1.sqlite.