test: clean up apply_patch allow-session artifact#24611
Merged
Conversation
owenlin0
approved these changes
May 26, 2026
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
approving_apply_patch_for_session_skips_future_prompts_for_same_fileintegration test writesapply_patch_allow_session.txtunder the process cwd while exercising outside-workspace patch approval behavior. Withjust testnow being the normal validation path, that file can be left behind in the checkout when the test runs or fails, creating confusing untracked state.What changed
apply_patch_allow_session.txtpath withtempfile::TempPathbefore the test removes and recreates it throughapply_patch.TempPathremove the generated file when the test exits, including panic paths.Verification
just test -p codex-core --test all approving_apply_patch_for_session_skips_future_prompts_for_same_file