Skip to content

[codex] remove plain image wrapper spans#24652

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/remove-image-wrapper
May 26, 2026
Merged

[codex] remove plain image wrapper spans#24652
pakrym-oai merged 1 commit into
mainfrom
pakrym/remove-image-wrapper

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

Why

Remote image submissions currently wrap native input_image spans in literal <image> and </image> text spans. Those extra prompt tokens add structure without providing label or routing information.

What Changed

  • Serialize UserInput::Image directly as an input_image content span.
  • Preserve named local-image framing and legacy wrapper parsing for labeled attachments and existing histories.
  • Update existing request-shape expectations for drag-and-drop images, model switching, and compaction.

Validation

  • just test -p codex-protocol
  • Focused codex-core run covering drag_drop_image_persists_rollout_request_shape, model_change_from_image_to_text_strips_prior_image_content, and snapshot_request_shape_pre_turn_compaction_including_incoming_user_message

Notes

  • A broader just test -p codex-core run was attempted; the affected tests passed, while the overall run failed in unrelated CLI, MCP, and tooling tests plus a thread_manager timeout.

@pakrym-oai pakrym-oai marked this pull request as ready for review May 26, 2026 22:18
@pakrym-oai pakrym-oai requested a review from a team as a code owner May 26, 2026 22:18
@pakrym-oai pakrym-oai merged commit 46391f7 into main May 26, 2026
31 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/remove-image-wrapper branch May 26, 2026 22:49
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants