[codex] remove plain image wrapper spans#24652
Merged
Merged
Conversation
dylan-hurd-oai
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remote image submissions currently wrap native
input_imagespans in literal<image>and</image>text spans. Those extra prompt tokens add structure without providing label or routing information.What Changed
UserInput::Imagedirectly as aninput_imagecontent span.Validation
just test -p codex-protocolcodex-corerun coveringdrag_drop_image_persists_rollout_request_shape,model_change_from_image_to_text_strips_prior_image_content, andsnapshot_request_shape_pre_turn_compaction_including_incoming_user_messageNotes
just test -p codex-corerun was attempted; the affected tests passed, while the overall run failed in unrelated CLI, MCP, and tooling tests plus athread_managertimeout.