Skip to content

[codex] Remove obsolete goal continuation turn marker#24658

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/remove-goal-continuation-turn-marker
May 27, 2026
Merged

[codex] Remove obsolete goal continuation turn marker#24658
pakrym-oai merged 1 commit into
mainfrom
pakrym/remove-goal-continuation-turn-marker

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

Why

continuation_turn_id was introduced to distinguish synthetic goal continuation turns for the no-tool continuation suppression heuristic. #20523 removed that heuristic, but left the marker behind. It is still written and cleared without affecting any runtime decision.

What Changed

  • Remove GoalRuntimeState::continuation_turn_id.
  • Remove the marker setter/clearer and their now-no-op start, finish, and abort call sites.

Testing

  • Not run yet (deferred at request).

@pakrym-oai pakrym-oai marked this pull request as ready for review May 26, 2026 22:46
@pakrym-oai pakrym-oai requested a review from a team as a code owner May 26, 2026 22:46
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had removed this as part of the earlier PR. Thanks for the cleanup.

@pakrym-oai pakrym-oai merged commit 0d37db4 into main May 27, 2026
31 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/remove-goal-continuation-turn-marker branch May 27, 2026 00:19
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants