Expose MCP server info as part of server status#24698
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5f9ac0200
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| #[ts(optional)] | ||
| pub server_info: Option<McpServerInfo>, |
There was a problem hiding this comment.
For v2 response payloads this attribute makes serverInfo disappear entirely whenever startup has not produced metadata, but the app-server v2 contract in AGENTS.md says not to use skip_serializing_if for v2 API fields so clients see a stable field with null instead of having to handle both missing and null. This matters for exactly the unavailable/failed-startup cases this Option is modeling.
Useful? React with 👍 / 👎.
|
@codex review this |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…-status # Conflicts: # codex-rs/app-server/tests/suite/v2/mcp_server_status.rs
…-status # Conflicts: # codex-rs/tui/src/markdown_render/table_key_value.rs
3 participants
Summary
Expose MCP server info via App Server (when available) so apps can render a richer MCP experience