Fix fs/watch debounce batching#24716
Merged
Merged
Conversation
etraut-openai
changed the title
etraut-openai
force-pushed
the
etraut/fix-fs-watch-debounce
branch
from
1753ffc to
b42029a
Compare
ddr-oai
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs/watchwas using a local debounce wrapper whose deadline was initialized once and then reused after the first batch. Once that stale deadline was in the past, later file changes could bypass the intended 200ms debounce and send noisierfs/changednotifications.This moves the debounce wrapper into
codex-file-watcherasDebouncedWatchReceiver, resets the debounce deadline for each event batch, preserves pending paths across cancelled receives, and updates app-serverfs/watchto use the shared wrapper.Fixes #24692.