Update rmcp to 1.7.0#24763
Conversation
anp-oai
force-pushed
the
codex/update-rmcp-1-7
branch
from
ede15b6 to
fb0368c
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ede15b6995
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Updates reqwest to 0.13 where needed for compatibility with rmcp.
anp-oai
force-pushed
the
codex/update-rmcp-1-7
branch
from
d6deb30 to
8af3fea
Compare
| OAuthState::Authorized(manager) => manager, | ||
| OAuthState::Unauthorized(manager) => manager, | ||
| OAuthState::Session(_) | OAuthState::AuthorizedHttpClient(_) => { | ||
| _ => { |
There was a problem hiding this comment.
Should we continue to be explicit so we're forced to update this code if a new variant is introduced?
There was a problem hiding this comment.
IMO maybe yes, but the rmcp update past 1.x moved these enums to be #[non_exhaustive] by default. I think if we wanted we could allow the non-exhaustive lint and still do exhaustive matching. WDYT?
There was a problem hiding this comment.
I don't feel that strongly. I suppose it's low enough probability that we would get a new variant that merits updating this code?
There was a problem hiding this comment.
Discussed offline, shipping as-is
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Thanks for doing this migration: it feels like there are a lot of ergonomic API improvements as part of this!
2 participants
WIll make it easier to uprev when the new draft spec is supported.
Also updates reqwest where needed for compatibility but doesn't update it everywhere since this is already a large diff.