feat(tui): make turn interruption keybind configurable#24766
Merged
Conversation
etraut-openai
approved these changes
May 27, 2026
91c2c58 to
6f40bbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Interrupting an active turn is currently fixed to
Esc, which is easy to hit accidentally and cannot be customized through/keymap. This gives users a less accidental binding while preserving the existing default.What Changed
tui.keymap.chat.interrupt_turnto/keymap, defaulting toescand supporting remapping or unbinding.request_user_input, including the visible hints.Escbehavior for popups, Vim insert mode, and/agentediting while validating conflicts with fixed/backtrack and request-input navigation bindings.How to Test
/keymap, then set Interrupt Turn tof12.Escno longer interrupts it whilef12does; the running hint should displayf12 to interrupt.f12; pressing it should interrupt and submit the steer immediately.request_user_inputprompt and confirm its footer usesf12; with notes open,Escshould still clear notes whilef12interrupts the turn.Ctrl+Cremains available.Targeted validation:
just write-config-schemajust fix -p codex-configjust fix -p codex-tuijust fmtjust argument-comment-lint-from-source -p codex-config -p codex-tuijust test -p codex-configcargo insta pending-snapshots --manifest-path tui/Cargo.tomljust test -p codex-tui keymap_setup::testsjust test -p codex-tui(fails in two pre-existing guardian feature-flag tests unrelated to this diff; the intentional picker snapshot updates were reviewed and accepted)