Thread Guardian cache key through session#24895
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ecbbfa35b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .with_prompt_cache_key_override( | ||
| crate::guardian::prompt_cache_key_override_for_review_session( |
There was a problem hiding this comment.
In this standalone commit, the new chain calls ModelClient::with_prompt_cache_key_override and guardian::prompt_cache_key_override_for_review_session, but neither symbol exists anywhere under codex-rs in this commit; git grep finds only this callsite. Any build of codex-core after applying just this split PR fails before tests, so this session-threading change cannot land independently of the companion API definitions.
Useful? React with 👍 / 👎.
1 participant
Split from the Guardian prompt cache key change. This PR only updates codex-rs/core/src/session/session.rs. Validation was not run per request; this branch is expected to rely on the companion split PRs.