Reap stale multi-agent slots#24903
Merged
Merged
Conversation
jif-oai
changed the title
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a8026d1ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jif-oai
force-pushed
the
jif/reap-stale-agent-slots
branch
from
9a8026d to
d881246
Compare
starr-openai
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close_agentclean up an agent that is still registered inAgentRegistryeven when its underlying thread is already missing.Closed, then treatThreadNotFound/InternalAgentDiedas a successful close so the registry slot can be released.close_agent("worker")succeeds after the worker thread has already disappeared.Motivation
A worker can disappear from
ThreadManagerwhile its metadata still exists in the rootAgentRegistry. Before this change, the close tool failed while trying to subscribe to the missing thread status, so it never reached the cleanup path that releases the registered agent slot. Withagents.max_threads = 1, an explicit close of that stale task-name agent could fail and leave the session unable to spawn a replacement.Scope
This PR intentionally does not add automatic stale-agent reaping to
spawn_agent,resume_agent, orlist_agents. A thread being missing fromThreadManageris not the same as an explicit close: persisted open spawn edges are still the durable source of truth for resume and task-name ownership untilclose_agentis called.Validation
just test -p codex-core -E 'test(multi_agent_v2_close_agent_reaps_stale_task_name_target) | test(resume_agent_from_rollout_reopens_open_descendants_after_manager_shutdown)'just fix -p codex-core