Skip to content

Add turn error lifecycle contributor#24916

Merged
jif-oai merged 1 commit into
mainfrom
jif/goal-turn-error-contributor
May 28, 2026
Merged

Add turn error lifecycle contributor#24916
jif-oai merged 1 commit into
mainfrom
jif/goal-turn-error-contributor

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 28, 2026

Summary

  • Add TurnErrorInput and TurnLifecycleContributor::on_turn_error to the extension API.
  • Emit the turn-error lifecycle from core turn error paths, including usage limit failures.
  • Add direct lifecycle coverage for the emitted error facts and stores.

Tests

  • just fmt
  • git diff --check
  • Not run: full tests or clippy (per instructions)

@jif-oai jif-oai requested a review from a team as a code owner May 28, 2026 13:45
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 28, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 28, 2026

Test failures are due to a GH flake

@jif-oai jif-oai merged commit e7d156e into main May 28, 2026
29 of 31 checks passed
@jif-oai jif-oai deleted the jif/goal-turn-error-contributor branch May 28, 2026 14:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant