Use internal model context fragments for goal steering#24918
Merged
Conversation
…goals # Conflicts: # codex-rs/core/src/goals.rs
Collaborator
Author
|
Windows is a transient failure |
etraut-openai
approved these changes
May 29, 2026
Collaborator
etraut-openai
left a comment
There was a problem hiding this comment.
Code looks good
I also manually tested that the TUI properly renders the goal prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Goal steering is one form of runtime-owned model context, but the old
<goal_context>wrapper made the contextual-fragment hiding path goal-specific. Using a source-labeled internal context fragment gives core and extensions a shared shape for hidden model steering while keeping those prompts out of visible turn history.The change also keeps legacy
<goal_context>messages recognized as hidden contextual input so existing stored history does not start rendering old goal-steering prompts as user-visible turn items.What Changed
GoalContextwithInternalModelContextFragmentplus a validatedInternalContextSource.<codex_internal_context source="goal">...</codex_internal_context>.ext/goalsteering to inject the new internal-context fragment.Test Coverage
<goal_context>fragments.source="goal"wrapper.