Conversation
sayan-oai
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #24813 added extension
TurnItemEmittercoverage and introduced a test that records a conversation history item before asserting extension-emitted turn item events.record_conversation_items()also emits aRawResponseItemevent to observers. The test was reading from the same event receiver and expected the next event to beItemStarted, so the test failed reliably once the setup history item was present.What Changed
Update
passes_turn_fields_and_scoped_turn_item_emitter_to_extension_callto consume and assert the expected setupRawResponseItembefore checking the extensionItemStarted,WebSearchBegin,ItemCompleted, andWebSearchEndevents.This is test-only and does not change extension runtime behavior.
Verification
cargo nextest run --no-fail-fast -p codex-core tools::handlers::extension_tools::tests::passes_turn_fields_and_scoped_turn_item_emitter_to_extension_call