Tighten hook output event schemas#24962
Merged
Merged
Conversation
eternal-openai
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #23993.
Hook command output schemas are published as the contract for hook authors and schema-driven tooling. The event-specific output schemas previously described
hookSpecificOutput.hookEventNameas the globalHookEventNameWireenum, so apre-tool-use.command.outputschema would validate mismatched values likePostToolUse. That made the schemas less precise than the intended event-specific contract.What
Constrain each hook-specific output schema to the matching literal
hookEventNamevalue, mirroring the existing input-schema shape.Also split
SubagentStartHookSpecificOutputWirefrom the session-start output wire sosubagent-start.command.output.schema.jsoncan emitconst: "SubagentStart"instead of sharing the session-start definition.Verification
cargo nextest run -p codex-hooksjust fix -p codex-hooksjust argument-comment-lint -p codex-hooks -- --all-targets