Skip to content

windows-sandbox: fix capture cancellation test roots#24974

Merged
bolinfest merged 1 commit into
mainfrom
pr24974
May 28, 2026
Merged

windows-sandbox: fix capture cancellation test roots#24974
bolinfest merged 1 commit into
mainfrom
pr24974

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented May 28, 2026

Why

The Windows Bazel job on main started failing after #24108 because one Windows-only capture test still passed cwd.as_path() to run_windows_sandbox_capture. That helper now expects the explicit workspace_roots slice introduced by #24108, so the Windows test target no longer compiled.

What Changed

  • Updates legacy_capture_cancellation_is_not_reported_as_timeout to pass workspace_roots_for(cwd.as_path()).as_slice(), matching the adjacent capture test and the new runner signature.

Verification

  • GitHub Actions CI is the important validation for this Windows-only compile path.
  • Created quickly to get Windows CI running while the separate Ubuntu compact_resume_fork timeout is still under investigation.

@bolinfest bolinfest merged commit bcf2b55 into main May 28, 2026
31 checks passed
@bolinfest bolinfest deleted the pr24974 branch May 28, 2026 22:51
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant