Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows Bazel job on
mainstarted failing after #24108 because one Windows-only capture test still passedcwd.as_path()torun_windows_sandbox_capture. That helper now expects the explicitworkspace_rootsslice introduced by #24108, so the Windows test target no longer compiled.What Changed
legacy_capture_cancellation_is_not_reported_as_timeoutto passworkspace_roots_for(cwd.as_path()).as_slice(), matching the adjacent capture test and the new runner signature.Verification
compact_resume_forktimeout is still under investigation.