Skip to content

Add runtime extra skill roots API#24977

Merged
xl-openai merged 1 commit into
mainfrom
dev/xl/skills
May 29, 2026
Merged

Add runtime extra skill roots API#24977
xl-openai merged 1 commit into
mainfrom
dev/xl/skills

Conversation

@xl-openai
Copy link
Copy Markdown
Collaborator

@xl-openai xl-openai commented May 28, 2026

Summary

  • Add v2 skills/extraRoots/set to replace app-server process-local standalone skill roots. The setting is not persisted, accepts missing roots, and extraRoots: [] clears the runtime set.
  • Wire runtime roots into core skill discovery for skills/list and turn loads, clear skill caches on set, and register the roots with the skills watcher so later filesystem changes emit skills/changed.
  • Update app-server docs, generated JSON/TypeScript schemas, and coverage for serialization, missing roots, empty clears, and restart behavior.

Testing

  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-core-skills
  • cargo test -p codex-app-server skills_extra_roots_set_updates_process_runtime_roots
  • just fix -p codex-app-server-protocol
  • just fix -p codex-core-skills
  • just fix -p codex-app-server

@xl-openai xl-openai requested a review from owenlin0 May 28, 2026 22:54
@xl-openai xl-openai marked this pull request as ready for review May 28, 2026 22:54
@xl-openai xl-openai merged commit f0a839e into main May 29, 2026
31 checks passed
@xl-openai xl-openai deleted the dev/xl/skills branch May 29, 2026 04:14
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants