Skip to content

Remove the debug-client CLI entrypoint#25067

Merged
jif-oai merged 1 commit into
mainfrom
jif/delete-debug-client-main-rs
May 29, 2026
Merged

Remove the debug-client CLI entrypoint#25067
jif-oai merged 1 commit into
mainfrom
jif/delete-debug-client-main-rs

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 29, 2026

Deletes codex-rs/debug-client/src/main.rs as one step in removing the stale app-server debug client.

This intentionally leaves Cargo workspace and lockfile cleanup for a later follow-up PR.

@jif-oai jif-oai changed the title Remove debug client entrypoint Remove the debug-client CLI entrypoint May 29, 2026
@jif-oai jif-oai marked this pull request as ready for review May 29, 2026 10:49
@jif-oai jif-oai merged commit e2b8ec6 into main May 29, 2026
8 of 31 checks passed
@jif-oai jif-oai deleted the jif/delete-debug-client-main-rs branch May 29, 2026 10:51
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc4c258b95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,310 +0,0 @@
mod client;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore a Cargo target before deleting main.rs

With this entrypoint removed while codex-rs/Cargo.toml still lists "debug-client" as a workspace member and debug-client/Cargo.toml has no [lib]/[[bin]], the workspace no longer parses: cargo metadata --no-deps --format-version 1 from codex-rs fails with no targets specified in the manifest. This blocks routine workspace commands such as just test -p ... until the package is removed from the workspace or given another target.

Useful? React with 👍 / 👎.

@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant