exec-server: add environment path refs#25121
Open
starr-openai wants to merge 3 commits into
Open
Conversation
starr-openai
force-pushed
the
starr/skills-path-ref-1-env-path-ref
branch
from
f525b07 to
0f9a588
Compare
starr-openai
force-pushed
the
starr/skills-path-ref-1-env-path-ref
branch
from
0f9a588 to
6c5eb2f
Compare
starr-openai
force-pushed
the
starr/skills-path-ref-1-env-path-ref
branch
6 times, most recently
from
eb0bf0b to
2fdb7c5
Compare
starr-openai
force-pushed
the
starr/skills-path-ref-1-env-path-ref
branch
from
2fdb7c5 to
d3938c8
Compare
starr-openai
force-pushed
the
starr/skills-path-ref-1-env-path-ref
branch
from
f1f663f to
b444724
Compare
starr-openai
force-pushed
the
starr/skills-path-ref-1-env-path-ref
branch
from
b444724 to
55ec07d
Compare
jif-oai
approved these changes
May 30, 2026
| self.file_system.read_directory(&self.path, sandbox).await | ||
| } | ||
|
|
||
| pub fn with_path(&self, path: AbsolutePathBuf) -> Self { |
Collaborator
There was a problem hiding this comment.
Ultra NIT, can we add some short doc-string on the pub functions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex_exec_server::EnvironmentPathRefStack
Validation
cd /Users/starr/code/codex-worktrees/pr-25098-restack4/codex-rs && just fmt