Set multi-agent v2 dogfood defaults#25266
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 560dc334b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f0324ed1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| subagent_usage_hint_text: Some( | ||
| DEFAULT_MULTI_AGENT_V2_SUBAGENT_USAGE_HINT_TEXT.to_string(), | ||
| ), |
There was a problem hiding this comment.
When a user sets [features.multi_agent_v2] usage_hint_enabled = false, the initial context now suppresses these hints, but spawn_agent still defaults fork_turns to all, and the full-history fork path in agent/control.rs appends config.multi_agent_v2.subagent_usage_hint_text whenever it is Some without checking usage_hint_enabled. Since this change makes the subagent hint Some by default, disabled multi-agent hints will still be injected into every default full-history subagent unless the user also knows to clear subagent_usage_hint_text = "".
Useful? React with 👍 / 👎.
2 participants
Summary
Tests
Note: a broad just test -p codex-core run was attempted locally, but this sandbox produced unrelated environment failures around sandbox-exec, missing test_stdio_server, and realtime timeouts.