Fix Windows running thread resume path normalization#25509
Merged
Conversation
etraut-openai
force-pushed
the
etraut/windows-resume-path-normalization
branch
from
d19ca44 to
231e4b8
Compare
Contributor
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This comment was marked as off-topic.
This comment was marked as off-topic.
bolinfest
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #24944.
On Windows, app-server resume could reject an active running thread when the requested session path used normal
C:\...form and the already-running path used verbatim\\?\C:\...form. The paths point at the same JSONL file, but the resume stale-path guard compared rawPathBufs, so desktop resume and heartbeat flows could fail with a mismatched-path error.What Changed
path_utils::paths_match_after_normalization.Verification
just test -p codex-app-server thread_resume_rejects_mismatched_path_for_running_thread_id