Skip to content

Preserve renamed thread titles during reconciliation#25624

Merged
jif-oai merged 1 commit into
mainfrom
jif/preserve-renamed-thread-title
Jun 1, 2026
Merged

Preserve renamed thread titles during reconciliation#25624
jif-oai merged 1 commit into
mainfrom
jif/preserve-renamed-thread-title

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Jun 1, 2026

Summary

  • preserve existing explicit SQLite thread titles during rollout reconciliation/backfill when the incoming rollout title is only first-message-derived
  • keep stale inferred-title repair behavior while avoiding session-index scans during startup backfill
  • add a regression test for renamed titles surviving reconcile

Testing

  • just fmt
  • just test -p codex-rollout
  • just test -p codex-state

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b123dc80cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/rollout/src/metadata.rs Outdated
@jif-oai jif-oai force-pushed the jif/preserve-renamed-thread-title branch from b123dc8 to cf52eb5 Compare June 1, 2026 14:26
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Jun 1, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf52eb5dab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/state/src/model/thread_metadata.rs
@jif-oai jif-oai merged commit 3cdce52 into main Jun 1, 2026
31 checks passed
@jif-oai jif-oai deleted the jif/preserve-renamed-thread-title branch June 1, 2026 16:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant