[codex] Publish release symbol artifacts#25649
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef21fca892
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nornagon-openai
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
anp-oai
left a comment
anp-oai
left a comment
There was a problem hiding this comment.
Seems reasonable at a high level, few questions on the details
2 participants
Why
Production Codex binaries are stripped for distribution, which leaves crashes and samples from released builds without the symbols needed for useful stack traces. Publish symbols as separate release assets so production artifacts stay small while released builds remain symbolicateable.
What changed
.github/scripts/archive-release-symbols-and-strip-binaries.shto package platform-native symbols intocodex-symbols-<artifact>.tar.gzassets while stripping the corresponding Unix binaries before signing..dSYMbundles, Linux.debugfiles with.gnu_debuglink, and Windows.pdbfiles.bwrapbefore computing its packaged-resource digest, but intentionally omitbwrapfrom symbol archives.Verification
shellcheckandbash -non.github/scripts/archive-release-symbols-and-strip-binaries.sh.git diff --check..dSYMcontains DWARF application source information and has the same UUID as the stripped production binary.codex.debug, excludesbwrap.debug, leaves the expected.gnu_debuglinkincodex, and does not mutate the separately strippedbwrapdigest..pdbfile.