Skip to content

Parallelize cold rollout compression#25654

Merged
jif-oai merged 1 commit into
mainfrom
jif/parallel-compression
Jun 1, 2026
Merged

Parallelize cold rollout compression#25654
jif-oai merged 1 commit into
mainfrom
jif/parallel-compression

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Jun 1, 2026

Why

#25089 added the background worker for compressing cold archived rollouts, but the worker still processed files effectively one at a time: each compression job was sent to spawn_blocking and then awaited before the next file started. On machines with a backlog of archived rollouts, that makes catch-up slower than it needs to be even though the actual compression work already runs off the async runtime.

What Changed

  • Queue rollout compression work in a JoinSet while directory traversal continues.
  • Cap the worker at two in-flight compression jobs so it can overlap compression without turning the background task into unbounded blocking work.
  • Drain pending jobs before returning, including the read_dir.next_entry() error path, so every launched job still contributes to the final compressed, skipped, and failed stats.
  • Treat task join failures the same way as compression failures in the worker's warning and failure accounting.

@jif-oai jif-oai changed the title feat: parallel compression Parallelize cold rollout compression Jun 1, 2026
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Jun 1, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 917a9a4 into main Jun 1, 2026
30 checks passed
@jif-oai jif-oai deleted the jif/parallel-compression branch June 1, 2026 17:54
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant