Skip to content

app-server: remove experimental persist_extended_history bool flag#25712

Merged
owenlin0 merged 1 commit into
mainfrom
owen/delete_persist_extended_history
Jun 1, 2026
Merged

app-server: remove experimental persist_extended_history bool flag#25712
owenlin0 merged 1 commit into
mainfrom
owen/delete_persist_extended_history

Conversation

@owenlin0
Copy link
Copy Markdown
Collaborator

@owenlin0 owenlin0 commented Jun 1, 2026

Summary

Remove the dead experimental persistExtendedHistory app-server flag and collapse rollout persistence to the single policy app-server already used.

What Changed

  • Removed persistExtendedHistory from v2 thread start/resume/fork params and deleted its deprecation notice path.
  • Removed the persistence-mode enums and plumbing through core, rollout, and thread-store.
  • Made rollout filtering mode-free, keeping the existing limited persisted-history behavior.

Test Plan

  • just write-app-server-schema
  • cargo nextest run --no-fail-fast -p codex-app-server-protocol schema_fixtures
  • cargo nextest run --no-fail-fast -p codex-app-server thread_shell_command_history_responses_exclude_persisted_command_executions
  • cargo nextest run --no-fail-fast -p codex-rollout -p codex-thread-store
  • final rg for removed flag/type names

@owenlin0 owenlin0 marked this pull request as ready for review June 1, 2026 23:15
@owenlin0 owenlin0 requested a review from a team as a code owner June 1, 2026 23:15
@owenlin0 owenlin0 requested a review from pakrym-oai June 1, 2026 23:15
@bolinfest bolinfest self-requested a review June 1, 2026 23:19
@owenlin0 owenlin0 enabled auto-merge (squash) June 1, 2026 23:24
@owenlin0 owenlin0 merged commit 11e0f3d into main Jun 1, 2026
31 checks passed
@owenlin0 owenlin0 deleted the owen/delete_persist_extended_history branch June 1, 2026 23:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants