Use Azure artifact signing environment secrets#25945
Merged
Merged
Conversation
47a61d4 to
74f799a
Compare
a5ca528 to
7cafa5a
Compare
9538ba9 to
f5bfe79
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5bfe79594
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows release signing should read Azure signing credentials from the
azure-artifact-signingenvironment instead of the old repo-levelAZURE_TRUSTED_SIGNING_*names. The smoke runs confirmed the environment secrets resolve with the newAZURE_ARTIFACT_SIGNING_*names once the Windows signing job is attached to that environment.What Changed
azure-artifact-signingenvironment.AZURE_TRUSTED_SIGNING_*toAZURE_ARTIFACT_SIGNING_*.workflow_call.secretsdeclarations for the old repo-level secret names; the caller continues to usesecrets: inherit.Validation
git diff --check -- .github/workflows/rust-release.yml .github/workflows/rust-release-windows.ymlruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "yaml ok: #{f}" }' .github/workflows/rust-release.yml .github/workflows/rust-release-windows.yml