Skip to content

Use Azure artifact signing environment secrets#25945

Merged
shijie-oai merged 12 commits into
mainfrom
dev/shijie/drop-windows-signing-deployment
Jun 4, 2026
Merged

Use Azure artifact signing environment secrets#25945
shijie-oai merged 12 commits into
mainfrom
dev/shijie/drop-windows-signing-deployment

Conversation

@shijie-oai
Copy link
Copy Markdown
Collaborator

@shijie-oai shijie-oai commented Jun 2, 2026

Why

Windows release signing should read Azure signing credentials from the azure-artifact-signing environment instead of the old repo-level AZURE_TRUSTED_SIGNING_* names. The smoke runs confirmed the environment secrets resolve with the new AZURE_ARTIFACT_SIGNING_* names once the Windows signing job is attached to that environment.

What Changed

  • Put the real Windows signing job in the azure-artifact-signing environment.
  • Switch the Windows signing action inputs from AZURE_TRUSTED_SIGNING_* to AZURE_ARTIFACT_SIGNING_*.
  • Drop the obsolete workflow_call.secrets declarations for the old repo-level secret names; the caller continues to use secrets: inherit.
  • Remove the temporary branch-trigger and Windows-only smoke-test workflow changes before finalizing this PR.

Validation

  • git diff --check -- .github/workflows/rust-release.yml .github/workflows/rust-release-windows.yml
  • ruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "yaml ok: #{f}" }' .github/workflows/rust-release.yml .github/workflows/rust-release-windows.yml

@shijie-oai shijie-oai marked this pull request as ready for review June 2, 2026 21:47
@shijie-oai shijie-oai force-pushed the dev/shijie/drop-windows-signing-deployment branch from 47a61d4 to 74f799a Compare June 2, 2026 21:56
@shijie-oai shijie-oai marked this pull request as draft June 2, 2026 21:59
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 2, 2026 23:06 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 2, 2026 23:06 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 2, 2026 23:07 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 2, 2026 23:07 — with GitHub Actions Failure
@shijie-oai shijie-oai temporarily deployed to azure-artifact-signing June 3, 2026 16:31 — with GitHub Actions Inactive
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 3, 2026 16:38 — with GitHub Actions Failure
@shijie-oai shijie-oai changed the title Allow Windows signing environment deployment Diagnose Windows signing environment secrets Jun 3, 2026
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 3, 2026 16:44 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 3, 2026 16:49 — with GitHub Actions Failure
@shijie-oai shijie-oai deployed to azure-artifact-signing June 3, 2026 16:57 — with GitHub Actions Active
@shijie-oai shijie-oai force-pushed the dev/shijie/drop-windows-signing-deployment branch from a5ca528 to 7cafa5a Compare June 3, 2026 17:10
@shijie-oai shijie-oai changed the title Diagnose Windows signing environment secrets Use Azure artifact signing environment secrets Jun 3, 2026
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 3, 2026 17:54 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 3, 2026 17:54 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 3, 2026 21:45 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 3, 2026 21:45 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 4, 2026 02:32 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 4, 2026 02:32 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 4, 2026 03:23 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 4, 2026 03:23 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 4, 2026 03:45 — with GitHub Actions Failure
@shijie-oai shijie-oai had a problem deploying to azure-artifact-signing June 4, 2026 03:45 — with GitHub Actions Failure
@shijie-oai shijie-oai force-pushed the dev/shijie/drop-windows-signing-deployment branch from 9538ba9 to f5bfe79 Compare June 4, 2026 04:11
@shijie-oai shijie-oai marked this pull request as ready for review June 4, 2026 04:59
@shijie-oai shijie-oai marked this pull request as draft June 4, 2026 06:30
@shijie-oai shijie-oai marked this pull request as ready for review June 4, 2026 17:31
@shijie-oai shijie-oai requested a review from bolinfest June 4, 2026 17:32
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5bfe79594

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/rust-release-windows.yml
@shijie-oai shijie-oai merged commit c3fcb0e into main Jun 4, 2026
31 checks passed
@shijie-oai shijie-oai deleted the dev/shijie/drop-windows-signing-deployment branch June 4, 2026 19:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants