[codex-api] observe auth updates on Responses WebSockets by cooper-oai · Pull Request #25952 · openai/codex

cooper-oai · 2026-06-02T22:14:37Z

Summary

apply URL-aware auth attachment and response observation to Responses WebSocket handshakes
observe successful, rejected, and wrapped-error headers and refresh the stream auth context after updates
bypass ambient proxies for explicit loopback WebSocket providers

Stack

PR 4 of 15. Depends on #25932. Followed by #25989.

Validation

just fmt
just test -p codex-api
just fix -p codex-api
just bazel-lock-check
git diff --check

cooper-oai · 2026-06-02T22:18:49Z

@codex review

chatgpt-codex-connector · 2026-06-02T22:26:13Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 803027bca1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cooper-oai · 2026-06-03T03:32:16Z

@codex review

chatgpt-codex-connector · 2026-06-03T03:34:21Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cooper-oai · 2026-06-03T04:08:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18d02d2577

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cooper-oai · 2026-06-03T04:45:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9704d8d222

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cooper-oai · 2026-06-03T05:05:11Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2b67b96e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cooper-oai · 2026-06-03T05:29:33Z

@codex review

chatgpt-codex-connector · 2026-06-03T05:40:37Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cooper-oai · 2026-06-03T09:55:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2df930c51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-03T10:04:42Z

+    let loopback_address = url.host_str().and_then(|host| {
+        host.parse::<IpAddr>()
+            .ok()
+            .filter(IpAddr::is_loopback)
+            .and_then(|_| url.port_or_known_default().map(|port| (host, port)))


Bypass proxies for localhost WebSocket providers

The local tokio-tungstenite connect path honors HTTP_PROXY/ALL_PROXY unless bypassed, but this new bypass only matches numeric loopback IPs because localhost fails host.parse::<IpAddr>(). A provider configured as http://localhost:11434/... therefore still falls through to connect_async_tls_with_config and can be tunneled through an ambient proxy in enterprise/CI environments, breaking local Responses WebSocket providers even though the comment says explicit loopback providers must not be proxied. Include localhost/name-resolution loopback in this bypass.

Useful? React with 👍 / 👎.

…les]

cooper-oai · 2026-06-03T11:02:46Z

Superseded by the collapsed seven-PR stack: #26137 through #26143. Closing this prototype layer to keep review focused.

This was referenced Jun 2, 2026

[codex-http-state] add generic per-surface HTTP state store #25930

Closed

[codex-app-server] expose per-surface HTTP state bridge #25931

Closed

[codex-api] add URL-scoped HTTP auth hooks #25932

Closed

cooper-oai marked this pull request as ready for review June 2, 2026 22:32

cooper-oai requested a review from a team as a code owner June 2, 2026 22:32

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread codex-rs/core/Cargo.toml Outdated

cooper-oai mentioned this pull request Jun 3, 2026

[codex] wire per-surface integrity state transport #25989

Closed

cooper-oai force-pushed the cooper/codex-native-integrity/3 branch 2 times, most recently from 13640ba to 6ba3d54 Compare June 3, 2026 02:51

cooper-oai force-pushed the cooper/codex-native-integrity/4 branch from 803027b to 32cf2ff Compare June 3, 2026 02:53

cooper-oai changed the title ~~[codex] wire native integrity state surfaces~~ [codex-api] observe auth updates on Responses WebSockets Jun 3, 2026

github-actions Bot mentioned this pull request Jun 3, 2026

📊 AI CLI 工具社区动态日报 2026-06-03 litang9/big_model_radar#6

Open

cooper-oai force-pushed the cooper/codex-native-integrity/3 branch from 6ba3d54 to 1d49c22 Compare June 3, 2026 04:04

cooper-oai force-pushed the cooper/codex-native-integrity/4 branch from 32cf2ff to 18d02d2 Compare June 3, 2026 04:04

cooper-oai mentioned this pull request Jun 3, 2026

[codex-login] reset per-surface HTTP state on login and logout #26027

Closed

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread codex-rs/codex-api/src/endpoint/responses_websocket.rs Outdated

Comment thread codex-rs/codex-api/src/endpoint/responses_websocket.rs Outdated

Comment thread codex-rs/codex-api/src/endpoint/responses_websocket.rs

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread codex-rs/codex-api/src/endpoint/responses_websocket.rs Outdated

Comment thread codex-rs/codex-api/src/endpoint/responses_websocket.rs Outdated

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread codex-rs/codex-api/src/endpoint/responses_websocket.rs

Comment thread codex-rs/codex-api/src/endpoint/responses_websocket_auth.rs Outdated

cooper-oai force-pushed the cooper/codex-native-integrity/3 branch from 1d49c22 to 2bd99fa Compare June 3, 2026 09:54

cooper-oai force-pushed the cooper/codex-native-integrity/4 branch from caa07aa to b2df930 Compare June 3, 2026 09:54

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

cooper-oai added 6 commits June 3, 2026 10:12

[codex-api] observe auth state on responses websockets [ci changed_fi…

f99045c

…les]

[codex-api] preserve chained websocket auth updates [ci changed_files]

7bf64be

[codex-api] keep websocket auth hook fixtures generic [ci changed_files]

51604c7

[codex-api] isolate websocket auth state handling [ci changed_files]

b5cf009

[codex-api] isolate websocket auth tests [ci changed_files]

35bb7ab

[codex-api] cover websocket auth propagation [ci changed_files]

bba3d95

cooper-oai force-pushed the cooper/codex-native-integrity/3 branch from 2bd99fa to 1bb047e Compare June 3, 2026 10:12

cooper-oai force-pushed the cooper/codex-native-integrity/4 branch from b2df930 to bba3d95 Compare June 3, 2026 10:12

cooper-oai closed this Jun 3, 2026

Conversation

cooper-oai commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Stack

Validation

Uh oh!

cooper-oai commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cooper-oai commented Jun 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 3, 2026

Uh oh!

cooper-oai commented Jun 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cooper-oai commented Jun 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

cooper-oai commented Jun 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

cooper-oai commented Jun 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 3, 2026

Uh oh!

cooper-oai commented Jun 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

cooper-oai commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cooper-oai commented Jun 2, 2026 •

edited

Loading