Skip to content

Restore Windows coverage for code-mode image generation exposure#25960

Merged
won-openai merged 1 commit into
mainfrom
codemode_imggen_integration_test_fix
Jun 3, 2026
Merged

Restore Windows coverage for code-mode image generation exposure#25960
won-openai merged 1 commit into
mainfrom
codemode_imggen_integration_test_fix

Conversation

@won-openai
Copy link
Copy Markdown
Collaborator

@won-openai won-openai commented Jun 2, 2026

Summary

Restore Windows coverage for standalone image generation in code mode.

The previous test executed a V8-backed code-mode cell on Windows CI, where that runtime path is intentionally excluded because it is unreliable. The test was then ignored entirely on Windows, removing useful coverage.

This splits the test into two checks:

  • All platforms verify that image_gen__imagegen is exposed to the model when image generation is configured for code mode only.
  • Non-Windows platforms continue to execute the full V8-backed flow and verify that the nested image-generation call succeeds.

Verification

  • just fmt
  • git diff --check
  • just test -p codex-app-server standalone_image_generation

Result: 3 tests passed, plus the required bench smoke check.

@won-openai won-openai merged commit 0eb7e6d into main Jun 3, 2026
46 of 47 checks passed
@won-openai won-openai deleted the codemode_imggen_integration_test_fix branch June 3, 2026 21:02
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants