[codex] cover attributable backend HTTP state#26081
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29ad9c050a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cooper-oai
force-pushed
the
cooper/codex-native-integrity/9
branch
from
ff25713 to
0f22670
Compare
cooper-oai
force-pushed
the
cooper/codex-native-integrity/10
branch
from
29ad9c0 to
cfc0c88
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
cooper-oai
force-pushed
the
cooper/codex-native-integrity/9
branch
from
0f22670 to
d41149a
Compare
cooper-oai
force-pushed
the
cooper/codex-native-integrity/10
branch
from
cfc0c88 to
6a61467
Compare
|
@codex review |
cooper-oai
force-pushed
the
cooper/codex-native-integrity/9
branch
from
d41149a to
0301b58
Compare
cooper-oai
force-pushed
the
cooper/codex-native-integrity/10
branch
from
6a61467 to
5e52e52
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e52e5215f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| codex-backend-openapi-models = { path = "../codex-backend-openapi-models" } | ||
| codex-api = { workspace = true } | ||
| codex-client = { workspace = true } | ||
| codex-http-state = { workspace = true } |
There was a problem hiding this comment.
Adding this workspace dependency changes the Rust dependency graph, but this commit updates only Cargo.toml/Cargo.lock and leaves MODULE.bazel.lock unchanged. The root repo guidance requires dependency changes to run just bazel-lock-update and include the refreshed lockfile (AGENTS.md lines 34-37); I also ran just bazel-lock-check, which reported MODULE.bazel.lock is out of date, so Bazel lock validation will fail until the regenerated lockfile is committed.
Useful? React with 👍 / 👎.
| #[test] | ||
| fn backend_headers_and_response_observation_rotate_native_http_state() { |
There was a problem hiding this comment.
This adds new unit coverage inside the inline test module in the main client.rs implementation file, but the repo test guidance says unit tests should go in a dedicated *_tests.rs file and to avoid test-only code in the main implementation (AGENTS.md lines 101-110). Please move this new backend HTTP-state test into a sibling test file so the implementation module does not keep growing with test-only code.
Useful? React with 👍 / 👎.
1 participant
Summary
codex-backend-clientapply URL-aware auth and observe response headers centrally/usageand credits-nudge requests to the initialized connection surfaceStack
PR 10 of 15. Depends on #26080. Followed by #26088.
Validation
CARGO_INCREMENTAL=0 just test -p codex-backend-clientget_account_rate_limits_returns_snapshotintegration testCARGO_INCREMENTAL=0 just fix -p codex-backend-client -p codex-app-serverjust fmtjust bazel-lock-checkgit diff --check