[codex-app-server] expose per-surface HTTP state bridge#26138
Open
cooper-oai wants to merge 1 commit into
Open
[codex-app-server] expose per-surface HTTP state bridge#26138cooper-oai wants to merge 1 commit into
cooper-oai wants to merge 1 commit into
Conversation
443ecd4 to
f8a301c
Compare
de6d167 to
6d4cc89
Compare
f8a301c to
ebda365
Compare
5d865be to
f5981ee
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de6d1675c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f5981ee to
44afe34
Compare
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Desktop-over-SSH and other remote app-server clients need to read and update the state file on the host running the app server. The bridge must remain surface-scoped: a client should not be able to mutate an arbitrary local jar.
What changed
httpState/get,httpState/set, andhttpState/clearapp-server methods.clientInfo.nameinstead of accepting a caller-supplied surface.expectedState. An omitted ornullvalue performs an unconditional replacement for minting and empty-jar seeding.Review guide
Stack
This is PR 2 of 7 in the native HTTP-state stack. It depends on #26137.
Validation
just write-app-server-schemajust fmtgit diff --checkjust test -p codex-app-server-protocoljust test -p codex-app-server http_state_bridgejust fix -p codex-app-server-protocol -p codex-app-serverjust bazel-lock-check