Route AGENTS.md loading through environment filesystems#26205
Merged
Conversation
anp-oai
force-pushed
the
codex/environment-manager-agents-md-loading
branch
from
862c3d0 to
76e5c6b
Compare
anp-oai
commented
Jun 3, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 3, 2026
anp-oai
commented
Jun 3, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 3, 2026
anp-oai
commented
Jun 3, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 3, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 3, 2026
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04a3f0a677
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jun 3, 2026
anp-oai
commented
Jun 3, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 3, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 3, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 3, 2026
pakrym-oai
reviewed
Jun 4, 2026
pakrym-oai
reviewed
Jun 4, 2026
pakrym-oai
reviewed
Jun 4, 2026
pakrym-oai
reviewed
Jun 4, 2026
pakrym-oai
approved these changes
Jun 4, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 4, 2026
anp-oai
force-pushed
the
codex/environment-manager-agents-md-loading
branch
from
787d48e to
32cf518
Compare
anp-oai
commented
Jun 4, 2026
| if let Ok(canon) = normalize_path(&dir) { | ||
| dir = AbsolutePathBuf::try_from(canon)?; | ||
| } | ||
| let dir = self.config.cwd.clone(); |
Collaborator
Author
There was a problem hiding this comment.
For posterity, self.config.cwd is already an AbsolutePathBuf and should have been normalized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Workspace-specific
AGENTS.mdloading needs to use the selected environment filesystem so remote workspaces and child agents read instructions from their actual environment instead of the host filesystem. The app-server should report the same instruction sources the initialized thread actually loaded, rather than independently rescanning configuration and filesystem state.What changed
LoadedAgentsMdto retain ordered user, project, and internal instructions with their provenance.AGENTS.mdpaths through the primaryEnvironmentManagerenvironment, then render the loaded instructions when constructing turn context.CODEX_HOMEloading and separator behavior while excluding empty project files that did not supply model-visible instructions.Validation
just test -p codex-core agents_mdjust test -p codex-core selected_environment_sources_match_model_visible_instructionsjust test -p codex-exec agents_mdjust test -p codex-app-server instruction_sourcesjust test -p codex-app-server --status-level fail