Skip to content

Cleanup experimentalFeature/enablement/set#26312

Merged
mzeng-openai merged 2 commits into
mainfrom
dev/mzeng/ignore-invalid-experimental-feature-keys
Jun 4, 2026
Merged

Cleanup experimentalFeature/enablement/set#26312
mzeng-openai merged 2 commits into
mainfrom
dev/mzeng/ignore-invalid-experimental-feature-keys

Conversation

@mzeng-openai
Copy link
Copy Markdown
Collaborator

@mzeng-openai mzeng-openai commented Jun 4, 2026

Why

experimentalFeature/enablement/set still allowed several keys that no longer need to be managed through this API. Keeping those keys also preserved corresponding special-case logic, including refreshing the apps list when the apps key was enabled.

The endpoint also rejected an entire request when any key was invalid or unsupported. That makes clients brittle when they send a mix of current and stale keys, even when the valid entries can still be applied safely.

What changed

  • remove the feature keys that no longer need to be supported by experimentalFeature/enablement/set
  • remove the corresponding apps-list refresh path and its auth/config plumbing
  • ignore and warn on invalid or unsupported keys while still applying valid keys from the same request
  • update the app-server documentation and integration coverage for the reduced key set and partial-acceptance behavior

Test plan

  • just test -p codex-app-server experimental_feature_enablement_set (6 passed)
  • just test -p codex-app-server exercised the changed tests successfully; unrelated sandbox-dependent and watcher/timing tests failed locally

@mzeng-openai mzeng-openai changed the title [codex] Ignore invalid experimental feature enablement keys Cleanup experimentalFeature/enablement/set Jun 4, 2026
@mzeng-openai mzeng-openai marked this pull request as ready for review June 4, 2026 05:46
@mzeng-openai mzeng-openai requested review from celia-oai and owenlin0 and removed request for owenlin0 June 4, 2026 05:46
@mzeng-openai mzeng-openai merged commit 4a70e0a into main Jun 4, 2026
31 checks passed
@mzeng-openai mzeng-openai deleted the dev/mzeng/ignore-invalid-experimental-feature-keys branch June 4, 2026 20:35
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants