Skip to content

app-server: support -c config overrides#26436

Merged
bolinfest merged 1 commit into
mainfrom
pr26436
Jun 4, 2026
Merged

app-server: support -c config overrides#26436
bolinfest merged 1 commit into
mainfrom
pr26436

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Jun 4, 2026

Why

The standalone codex-app-server binary already routed a CliConfigOverrides value into app-server startup, but its own clap args did not expose the shared -c/--config option. That meant codex-app-server -c key=value was rejected before the existing config override path could run, unlike the main codex CLI.

What Changed

  • Flatten CliConfigOverrides into AppServerArgs in codex-rs/app-server/src/main.rs.
  • Pass parsed overrides to run_main_with_transport_options instead of always using CliConfigOverrides::default().
  • Add a binary parser test covering both -c and --config for the standalone app-server.

Verification

  • just test -p codex-app-server app_server_accepts_cli_config_overrides

The broader just test -p codex-app-server run was also attempted. It compiled and ran 812 tests, with 796 passing, but failed in this local sandbox on unrelated sandbox-exec: sandbox_apply: Operation not permitted command-exec/turn integration paths and a skills watcher timeout.

@bolinfest bolinfest changed the title app-server: support CLI config overrides app-server: support -c config overrides Jun 4, 2026
@bolinfest bolinfest requested a review from dylan-hurd-oai June 4, 2026 17:56
@bolinfest bolinfest enabled auto-merge (squash) June 4, 2026 17:57
@bolinfest bolinfest merged commit 881cf19 into main Jun 4, 2026
46 checks passed
@bolinfest bolinfest deleted the pr26436 branch June 4, 2026 18:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants