[codex] Fix Windows sandbox build script lint#26445
Merged
Merged
Conversation
anp-oai
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows ARM64 Cargo clippy job on
mainis failing because workspace lints denyclippy::expect_used, and thecodex-windows-sandboxbuild script usedexpect()while readingCARGO_MANIFEST_DIR.What changed
codex-rs/windows-sandbox-rs/build.rsnow returnsResult<(), String>frommain()and converts a missingCARGO_MANIFEST_DIRinto an explicit build-script error. The non-Windows early return and Windows linker argument behavior are unchanged.Verification
just clippy -p codex-windows-sandbox -- -D warningsjust test -p codex-windows-sandbox