Skip to content

[codex] Use model-advertised reasoning effort order#26446

Merged
aibrahim-oai merged 3 commits into
mainfrom
codex/reasoning-effort-list-order
Jun 4, 2026
Merged

[codex] Use model-advertised reasoning effort order#26446
aibrahim-oai merged 3 commits into
mainfrom
codex/reasoning-effort-list-order

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai commented Jun 4, 2026

Summary

  • preserve the model catalog order for app-server supportedReasoningEfforts and document that client contract
  • render TUI reasoning choices in the advertised order
  • step reasoning shortcuts by adjacent list position instead of deriving order from known effort names
  • anchor unsupported configured values to the advertised default, or the first option when needed
  • remove canonical effort ordering helpers and the unused upgrade effort mapping

Validation

  • just fmt
  • Local tests and compilation were not run per request; relying on CI.

Stacked on #26444.

@aibrahim-oai aibrahim-oai force-pushed the codex/reasoning-effort-list-order branch 2 times, most recently from 872689b to c120fec Compare June 4, 2026 19:24
@aibrahim-oai
Copy link
Copy Markdown
Collaborator Author

aibrahim-oai commented Jun 4, 2026

This change is part of the following stack:

Change managed by git-spice.

@aibrahim-oai aibrahim-oai force-pushed the codex/reasoning-effort-list-order branch 3 times, most recently from a6fd017 to 0fc031c Compare June 4, 2026 19:50
@aibrahim-oai
Copy link
Copy Markdown
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Base automatically changed from codex/model-defined-reasoning-efforts to main June 4, 2026 20:36
@aibrahim-oai aibrahim-oai requested a review from a team as a code owner June 4, 2026 20:36
@aibrahim-oai aibrahim-oai force-pushed the codex/reasoning-effort-list-order branch from 0fc031c to 73ba172 Compare June 4, 2026 20:45
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested that reasoning effort options preserve the model-advertised order and exact string values across app-server and TUI selection and shortcuts.

Code looks good as well, approved. 👍

@aibrahim-oai aibrahim-oai enabled auto-merge (squash) June 4, 2026 20:46
@aibrahim-oai aibrahim-oai disabled auto-merge June 4, 2026 21:01
@aibrahim-oai aibrahim-oai merged commit f6e5296 into main Jun 4, 2026
44 of 61 checks passed
@aibrahim-oai aibrahim-oai deleted the codex/reasoning-effort-list-order branch June 4, 2026 21:01
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants