Skip to content

Remove response.processed websocket request#26447

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/remove-response-processed-websocket-request
Jun 4, 2026
Merged

Remove response.processed websocket request#26447
pakrym-oai merged 1 commit into
mainfrom
pakrym/remove-response-processed-websocket-request

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

Why

The Responses websocket client no longer needs to send a follow-up response.processed request after a turn response has already been recorded. Keeping that extra acknowledgement path adds feature-gated control flow and a second websocket request shape that no longer carries useful behavior.

What Changed

  • Removed the response.processed websocket request type and sender.
  • Removed the responses_websocket_response_processed feature flag and schema entry.
  • Removed turn and remote-compaction plumbing that only tracked response IDs to send the acknowledgement.
  • Removed tests that existed solely to cover the deleted feature path.

Validation

  • just fix -p codex-core -p codex-api -p codex-features

@pakrym-oai pakrym-oai marked this pull request as ready for review June 4, 2026 19:14
@pakrym-oai pakrym-oai requested a review from a team as a code owner June 4, 2026 19:14
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e2e3b1c66

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/features/src/lib.rs
@pakrym-oai pakrym-oai enabled auto-merge (squash) June 4, 2026 20:14
@pakrym-oai pakrym-oai merged commit d312a53 into main Jun 4, 2026
43 of 47 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/remove-response-processed-websocket-request branch June 4, 2026 20:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants