feat(tui): show tab activity detail by fcoury-oai · Pull Request #26476 · openai/codex

fcoury-oai · 2026-06-04T22:23:35Z

Why

The structured status is most useful when it explains what Codex is doing or what needs user attention. This layer adds that detail while bounding terminal output and avoiding high-frequency OSC writes.

What Changed

show running commands, status headers, and the most recent completed activity
describe approval, permission, MCP, tool-suggestion, and tool-input waits
select concurrent command detail deterministically by start order
sanitize control, bidi, and invisible characters; escape OSC separators; cap detail length
throttle detail-only updates to 250 ms while allowing state changes immediately

How to Test

Run Codex in iTerm2 and start commands, including overlapping commands.
Confirm Working detail follows the newest running command and falls back to the surviving command when it completes.
Open an approval or tool-input prompt and confirm Waiting detail describes the request.
Complete the turn and confirm Idle shows the last activity.

Targeted tests:

just test -p codex-tui tab_status
just test -p codex-tui osc_text
just test -p codex-tui picks_the_latest_command_then_falls_back_to_the_survivor

The full codex-tui run passed 2,800 tests; two unrelated guardian feature-flag tests remain failing on main.

Stack

#26474 base OSC 21337 tab status
#26475 flattened shell command display
feat(tui): show tab activity detail #26476 detailed and throttled tab activity (this PR)

Part of #25879.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd8bcd9624

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-06-05T17:26:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef38cb7e47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-06-05T17:37:33Z

@codex review

fcoury-oai · 2026-06-05T17:38:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6d85dedf0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-06-05T17:58:52Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 620df376c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-05T18:05:15Z

-//! OSC 21337 is an iTerm2 extension; other terminals ignore it. The payload
-//! is a semicolon-separated list of `key=value` pairs. We emit `status`
-//! (label), `indicator` (dot color), and `status-color` (text color).
+//! Formats bounded activity detail and owns the low-level terminal write path.


Split complex tab-status detail change

This commit is 799 changed lines across 22 files and is not mechanical: it combines OSC detail formatting/sanitization and throttling, bottom-pane waiting-detail plumbing, command/activity tracking, and test updates. The change-size guidance says complex logic changes should stay under 500 lines and, when larger, identify a staged split (AGENTS.md lines 114-120); a reviewable split would be to land the bounded OSC/detail formatting and throttle state with tests first, then wire command/activity and modal detail providers in a follow-up.

Useful? React with 👍 / 👎.

I reduced this layer from 799 to 749 changed lines by moving the shared OSC sanitizer and terminal-title reuse into PR1, where it is independently tested. This PR remains the third layer of the explicitly requested three-PR stack; splitting the remaining detail plumbing would require a fourth PR. I am leaving this thread open for maintainer visibility.

Co-authored-by: George Nachman <gnachman@gmail.com>

fcoury-oai · 2026-06-05T18:31:23Z

@codex review

chatgpt-codex-connector · 2026-06-05T18:35:20Z

Security review completed. No security issues were found in this pull request.

View security finding report

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector · 2026-06-05T18:36:22Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This was referenced Jun 4, 2026

feat(tui): emit iTerm2 tab status #26474

Open

fix(tui): display flattened shell commands #26475

Open

fcoury-oai force-pushed the fcoury/iterm-tab-status-shell-command branch from ecf6985 to f1ad153 Compare June 5, 2026 15:21

fcoury-oai force-pushed the fcoury/iterm-tab-status-detail branch from 07736d1 to d04ac5c Compare June 5, 2026 15:21

fcoury-oai force-pushed the fcoury/iterm-tab-status-shell-command branch from f1ad153 to 14e20be Compare June 5, 2026 16:26

fcoury-oai force-pushed the fcoury/iterm-tab-status-detail branch 2 times, most recently from e839871 to bd8bcd9 Compare June 5, 2026 16:39

fcoury-oai marked this pull request as ready for review June 5, 2026 16:56

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

Comment thread codex-rs/tui/src/bottom_pane/tab_status_state.rs

Comment thread codex-rs/tui/src/bottom_pane/mod.rs Outdated

Comment thread codex-rs/tui/src/tab_status.rs

fcoury-oai force-pushed the fcoury/iterm-tab-status-detail branch from bd8bcd9 to ef38cb7 Compare June 5, 2026 17:25

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

Comment thread codex-rs/tui/src/bottom_pane/mod.rs

Comment thread codex-rs/tui/src/bottom_pane/approval_overlay.rs Outdated

Comment thread codex-rs/tui/src/tab_status.rs Outdated

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

Comment thread codex-rs/tui/src/bottom_pane/mod.rs

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

fcoury-oai force-pushed the fcoury/iterm-tab-status-shell-command branch from 27d665c to 8da1e5c Compare June 5, 2026 18:15

fcoury-oai and others added 6 commits June 5, 2026 15:28

feat(tui): show tab activity detail

5f924b3

Co-authored-by: George Nachman <gnachman@gmail.com>

fix(tui): stabilize tab status detail updates

29b834a

fix(tui): keep flattened tab status commands

58f5ec3

fix(tui): bound tab detail formatting

6b0a161

fix(tui): cap elicitation tab detail

91a55ba

fix(tui): bound cached tab activity

94bceb2

fcoury-oai force-pushed the fcoury/iterm-tab-status-detail branch from 620df37 to 94bceb2 Compare June 5, 2026 18:30

Conversation

fcoury-oai commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What Changed

How to Test

Stack

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcoury-oai commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcoury-oai commented Jun 5, 2026

Uh oh!

fcoury-oai commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury-oai commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

fcoury-oai Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcoury-oai commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fcoury-oai commented Jun 4, 2026 •

edited

Loading