Propagate safety buffering events to app-server clients#29371
Merged
Conversation
| turn_state: Option<&OnceLock<String>>, | ||
| ) -> Result<(), ApiError> { | ||
| let mut last_server_model: Option<String> = None; | ||
| let mut safety_buffering_emitted = false; |
Collaborator
There was a problem hiding this comment.
I think we don't need that. let's send all notifications
aibrahim-oai
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responses API safety buffering metadata currently stops at the transport boundary, so app-server clients cannot render the in-progress safety review state.
This change:
safety_bufferingmetadata from Responses API SSE and WebSocket events without suppressing the original response eventturn/safetyBuffering/updatedthrough app-server v2 and updates generated protocol schemasThis supports the Codex Apps buffering UX and depends on the Responses API backend work in https://github.com/openai/openai/pull/1044569 and https://github.com/openai/openai/pull/1044571.
Validation:
codex-coresafety-buffering integration test passescargo check -p codex-core -p codex-app-server -p codex-app-server-protocoljust fix -p codex-api -p codex-protocol -p codex-core -p codex-app-server-protocol -p codex-app-server -p codex-rollout -p codex-rollout-trace -p codex-oteljust fmt