Skip to content

fix(app-server): suppress TUI rollback warning#30124

Merged
fcoury-oai merged 1 commit into
mainfrom
fcoury/fix-rollback-deprecation
Jun 25, 2026
Merged

fix(app-server): suppress TUI rollback warning#30124
fcoury-oai merged 1 commit into
mainfrom
fcoury/fix-rollback-deprecation

Conversation

@fcoury-oai

Copy link
Copy Markdown
Contributor

Why

The TUI uses thread/rollback internally for user-facing flows such as prompt cancellation/backtracking. After thread/rollback was marked deprecated, those internal calls started surfacing deprecationNotice messages in the TUI, even though the user did not explicitly call the deprecated app-server API.

The endpoint should remain deprecated for external app-server clients, but the built-in codex-tui client should not show this implementation-detail warning during normal interaction.

What changed

  • Pass the initialized app-server client name into the thread/rollback request processor.
  • Suppress the thread/rollback deprecation notice only for codex-tui.
  • Preserve the existing deprecationNotice behavior for non-TUI clients.
  • Add regression coverage for the codex-tui suppression path.

How to Test

  1. Start Codex TUI from this branch.
  2. Type text into the composer and press Esc to cancel/backtrack.
  3. Confirm the TUI restores/cancels the prompt without showing thread/rollback is deprecated and will be removed soon.
  4. Also verify an external app-server client that calls thread/rollback still receives deprecationNotice.

Targeted tests:

  • just test -p codex-app-server thread_rollback
  • just argument-comment-lint

@fcoury-oai fcoury-oai merged commit b80fbb7 into main Jun 25, 2026
31 checks passed
@fcoury-oai fcoury-oai deleted the fcoury/fix-rollback-deprecation branch June 25, 2026 21:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants