fix(app-server): suppress TUI rollback warning#30124
Merged
Merged
Conversation
owenlin0
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TUI uses
thread/rollbackinternally for user-facing flows such as prompt cancellation/backtracking. Afterthread/rollbackwas marked deprecated, those internal calls started surfacingdeprecationNoticemessages in the TUI, even though the user did not explicitly call the deprecated app-server API.The endpoint should remain deprecated for external app-server clients, but the built-in
codex-tuiclient should not show this implementation-detail warning during normal interaction.What changed
thread/rollbackrequest processor.thread/rollbackdeprecation notice only forcodex-tui.deprecationNoticebehavior for non-TUI clients.codex-tuisuppression path.How to Test
Escto cancel/backtrack.thread/rollback is deprecated and will be removed soon.thread/rollbackstill receivesdeprecationNotice.Targeted tests:
just test -p codex-app-server thread_rollbackjust argument-comment-lint