Report MCP OAuth Auto store drift#30296
Open
stevenlee-oai wants to merge 7 commits into
Open
Conversation
This was referenced Jun 26, 2026
f1a3e95 to
ed8c216
Compare
04aa181 to
96b3707
Compare
ed8c216 to
2e95aa0
Compare
96b3707 to
71071e9
Compare
71071e9 to
857c0dd
Compare
2e95aa0 to
51f18bc
Compare
# Conflicts: # codex-rs/rmcp-client/src/oauth.rs # codex-rs/rmcp-client/src/oauth/resolved_store.rs
This was referenced Jun 27, 2026
…ing' into dev/stevenlee/mcp-oauth-independent-5-auto-diagnostics
…ing' into dev/stevenlee/mcp-oauth-independent-5-auto-diagnostics
…ing' into dev/stevenlee/mcp-oauth-independent-5-auto-diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex Thread 019edd6d-6f14-74e2-853c-345d1803d4a6
Stack
Review and merge in order. Every layer is independently correct and documents its safe stopping point.
This PR is layer 6.
Why
Auto is intentionally resolved once and pinned only for a client lifecycle in this stack. If keyring availability differs in a later process, Auto can resolve to a different store. We do not want to add a durable credential-authority selector or migration policy in this stack, but we do want evidence if this rare assumption fails in practice.
What this PR does
$CODEX_HOME/.mcp-oauth-store-resolutions.json.compute_store_key(server_name, url)identity used by credential locking.codex.mcp.oauth.store_resolution_changedcounter when repeated Auto resolution under the same backend changes stores.Explicit decisions
CODEX_HOME; different homes are intentionally independent.Safe stopping point
This PR changes observability only. The five correctness layers below it are independently complete without this diagnostic.
Validation
just test -p codex-rmcp-client(116 passed; expected environment skips)