[codex] fix status line full access label#30597
Draft
ssetty-oai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No Sandboxin the TUI status line when sandboxing is disabled but command approvals are still enabled.Full Accessfor disabled sandboxing withAskForApproval::Never.Why
The compact status line derived its permissions label only from
PermissionProfile::Disabled, sosandbox_mode = "danger-full-access"with an approval policy such asOnRequestwas misleadingly shown asFull Accesseven though commands still required approval.User impact
Users can now distinguish an unsandboxed session that still asks for approval from a truly unrestricted full-access session.
Closes #30379
Testing
just fmtCARGO_TARGET_DIR=/tmp/codex-target just test -p codex-tui status_line_permissions_distinguish_no_sandbox_from_full_accessCARGO_TARGET_DIR=/tmp/codex-target just test -p codex-tui status_surface_preview_no_sandbox_with_approval_snapshotCARGO_TARGET_DIR=/tmp/codex-target just test -p codex-tui(2950 passed; two unrelated existing Guardian feature-flag tests fail independently:app::tests::update_feature_flags_disabling_guardian_clears_manual_review_policy_without_historyandapp::tests::update_feature_flags_disabling_guardian_clears_review_policy_and_restores_default, both withErr(Empty).)