core: track thread publication lifecycle#31333
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7f986f65a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
c7f986f to
357dede
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5e66c6979
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Summary
ThreadIdin a manager-scoped treeWhy
The follow-up descendant-activity gate needs a durable identity tree keyed by the same thread IDs used by app-server and ChatGPT. This stage owns only registration, publication, replacement isolation, and cleanup; activity reservations and completion delivery remain in the next PR so each concurrency contract is independently reviewable.
Stack
Validation
CARGO_INCREMENTAL=0 just test -p codex-core registration_and_publication_preserve_thread_incarnations dropped_tree_handles_are_pruned_leaf_to_rootCARGO_INCREMENTAL=0 just fix -p codex-corejust fmtThe two focused tests passed before the final fix/format pass; tests were not rerun afterward, per repository guidance.