exec-server: start managed network proxy on executor#31453
Draft
viyatb-oai wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Core currently prepares orchestrator-local loopback endpoints for remote commands. The remote sandbox receives those ports, but exec-server never creates a reachable proxy on the executor, so managed networking fails closed without usable egress.
Testing
just test -p codex-exec-server remote_proxy_config_starts_executor_local_proxyjust test -p codex-exec-server-protocolcodex-network-proxypolicy conversion tests passed in the crate run; four unrelated MITM certificate tests could not write to the sandboxed~/.codex/proxyStack follow-up: preserve inline Guardian network decisions across the exec-server transport.