Skip to content

gracefully handle SSE parse errors and suppress raw parser code#367

Merged
tibo-openai merged 8 commits intoopenai:mainfrom
Suyash-K:fix/suppress-sse-parse-error
Apr 19, 2025
Merged

gracefully handle SSE parse errors and suppress raw parser code#367
tibo-openai merged 8 commits intoopenai:mainfrom
Suyash-K:fix/suppress-sse-parse-error

Conversation

@Suyash-K
Copy link
Contributor

@Suyash-K Suyash-K commented Apr 18, 2025

Closes #187
Closes #358

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Suyash-K
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 18, 2025
@Suyash-K
Copy link
Contributor Author

Suyash-K commented Apr 18, 2025

Summary

This PR removes the low-level SSE parser bundle that was causing confusion and maintenance overhead, as noted in #358 and #187. The change prevents malformed JSON parsing issues.

After Fix (Locally Run)

Screenshot 2025-04-19 035249

Before Fix

Screenshot 2025-04-19 013205

@tibo-openai
Copy link
Collaborator

tibo-openai commented Apr 18, 2025

ty! Would merge, but ci is failing, could you have a look at this @Suyash-K ?

@Suyash-K
Copy link
Contributor Author

ty! Would merge, but ci is failing, could you have a look at this @Suyash-K ?

It was failing formatting tests 'cause of Prettier style violations can you check this commit commit 5874abf and see if it works @tibo-openai ?

@tibo-openai
Copy link
Collaborator

merging, ty!

@tibo-openai tibo-openai merged commit b37b257 into openai:main Apr 19, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(cli): hide internal SSE parser stack trace on parse errors something about having an insuficient quota

2 participants