Skip to content

Conversation

@mayphus
Copy link

@mayphus mayphus commented Sep 19, 2025

Summary

  • handle Ctrl+P and Ctrl+N chords in the composer textarea so vertical movement works across terminals
  • map the fallback C0 control bytes for those chords to the same navigation paths in both the composer and generic list selection popups
  • wire the same shortcuts into list selection popups so Emacs-style navigation works consistently
  • extend textarea and list selection tests to cover both the modifier chords and C0 fallbacks

Testing

  • cargo test -p codex-tui
  • just fmt
  • just fix -p codex-tui

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mayphus
Copy link
Author

mayphus commented Sep 19, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 19, 2025
@mayphus mayphus changed the title Add Ctrl+P/Ctrl+N navigation to the TUI composer Add Ctrl+P/Ctrl+N navigation across composer and selection popups Sep 19, 2025
@mayphus mayphus force-pushed the feature/textarea-ctrl-pn branch from 524f383 to 973697f Compare September 21, 2025 05:28
@etraut-openai
Copy link
Collaborator

Thanks for the contribution, and apologies for the slow response. We've received many PRs, and we don't have the bandwidth on the codex team to review all of them.

We've updated our contribution guidelines to clarify that we're currently accepting contributions for bugs and security fixes, but we're not generally accepting new features at this time. We need to make sure that all new features compose well with both existing and upcoming features and fit into our roadmap. If you would like to propose a new feature, please file or upvote an enhancement request in the issue tracker. We will generally prioritize new features based on community feedback.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
@openai openai unlocked this conversation Oct 30, 2025
youta7 added a commit to youta7/ta-codex that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants