Surface context window error to the client#4675
Merged
aibrahim-oai merged 21 commits intomainfrom Oct 5, 2025
Merged
Conversation
aibrahim-oai
changed the title
Collaborator
Author
|
@codex review this |
Contributor
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
pakrym-oai
reviewed
Oct 3, 2025
pakrym-oai
reviewed
Oct 3, 2025
pakrym-oai
reviewed
Oct 3, 2025
pakrym-oai
reviewed
Oct 3, 2025
pakrym-oai
reviewed
Oct 3, 2025
pakrym-oai
reviewed
Oct 3, 2025
pakrym-oai
requested changes
Oct 3, 2025
Collaborator
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
few comments. the main one is what do we expect users to do after seeing this message?
jif-oai
approved these changes
Oct 4, 2025
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Ok once all the comments are fixed
pakrym-oai
reviewed
Oct 4, 2025
pakrym-oai
reviewed
Oct 4, 2025
pakrym-oai
reviewed
Oct 4, 2025
pakrym-oai
reviewed
Oct 4, 2025
pakrym-oai
reviewed
Oct 4, 2025
pakrym-oai
approved these changes
Oct 4, 2025
bolinfest
reviewed
Oct 8, 2025
| } | ||
|
|
||
| fn is_context_window_error(error: &Error) -> bool { | ||
| error.code.as_deref() == Some("context_length_exceeded") |
Collaborator
There was a problem hiding this comment.
Where does this string come from? Is there some const we should be referencing here instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, we were treating
input exceeded context windowas a streaming error and retrying on it. Retrying on it has no point because it won't change the behavior. In this PR, we surface the error to the client without retry and also send a token count event to indicate that the context window is full.