-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Handle "Don't Trust" directory selection in onboarding #4941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4a1b282
feat: add project trust level and untrusted support
vmotta8 427575c
Merge branch 'main' into main
vmotta8 55ba23b
style: cargo fmt executed
vmotta8 967eb65
style: fix import formatting for CI
vmotta8 186dffd
Merge branch 'main' into main
vmotta8 2c64137
fix: adjust tests to allow ReadOnly sandbox on Windows
vmotta8 482e81c
Merge branch 'main' into main
vmotta8 042c626
fix: use tempdir and construct ConfigToml in test
vmotta8 160f491
feat: use TrustLevel enum for project trust
vmotta8 d94952a
fix: pass TrustLevel by value in config setter
vmotta8 74f34d3
style: wrap long call arguments for readability
vmotta8 324a39a
Merge branch 'main' into main
etraut-openai 84acf7f
fix: show trust screen only when trust not set
vmotta8 d7133f7
Merge branch 'main' into main
vmotta8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no sandbox on Windows today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just to clarify: the test expects ReadOnly on Windows due to the downgrade logic, but since there's no actual sandbox on Windows, should I remove this assertion or handle it differently?