[Auth] Introduce New Auth Storage Abstraction for Codex CLI #5569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
celia-oai
changed the title
celia-oai
force-pushed
the
dev/cc/auth-new-abstraction
branch
3 times, most recently
from
a1e8077 to
c75857a
Compare
celia-oai
changed the title
celia-oai
requested review from
bolinfest,
gpeal,
owenlin0,
pakrym-oai and
pkomlev
and removed request for
pkomlev
gpeal
reviewed
Oct 23, 2025
|
I have read the CLA Document and I hereby sign the CLA |
gpeal
reviewed
Oct 24, 2025
gpeal
approved these changes
Oct 24, 2025
celia-oai
force-pushed
the
dev/cc/auth-new-abstraction
branch
from
9561e19 to
36935e7
Compare
pakrym-oai
reviewed
Oct 25, 2025
pakrym-oai
reviewed
Oct 25, 2025
pakrym-oai
reviewed
Oct 25, 2025
pakrym-oai
approved these changes
Oct 25, 2025
celia-oai
force-pushed
the
dev/cc/auth-new-abstraction
branch
4 times, most recently
from
e470ea8 to
11ac69d
Compare
celia-oai
force-pushed
the
dev/cc/auth-new-abstraction
branch
4 times, most recently
from
3a3c1d3 to
068a3b7
Compare
pakrym-oai
approved these changes
Oct 27, 2025
celia-oai
force-pushed
the
dev/cc/auth-new-abstraction
branch
from
07d197a to
8b9e633
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Auth Storageabstraction layer that takes care of read, write, and load of auth tokens based on the AuthCredentialsStoreMode. It is similar to how we handle MCP client oauth here. Instead of reading and writing directly from disk for auth tokens, Codex CLI workflows now should instead use this auth storage using the public helper functions.This PR is just a refactor of the current code so the behavior stays the same. We will add support for keyring and hybrid mode in follow-up PRs.
I have read the CLA Document and I hereby sign the CLA