-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[Auth] Add keyring support for Codex CLI #5591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
02000ee to
1294543
Compare
9561e19 to
36935e7
Compare
60fe5bf to
36bc480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
https://github.com/openai/codex/blob/36bc4807cb14bbfddd71f4e23077f1e999b1cd5d/codex-rs/core/src/auth.rs#L475-L477
Honor keyring storage modes when accessing CLI auth
The new AuthCredentialsStoreMode adds Keyring/Auto backends, but the top‑level helpers still instantiate storage with AuthCredentialsStoreMode::File (see logout, and similarly save_auth/load_auth_dot_json). As a result the CLI never reads or writes via the keyring and logout cannot remove keyring entries, so the feature introduced in this commit is effectively dead code. This should default to the keyring‑backed mode (or accept a user preference) so credentials are stored and deleted consistently.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
36bc480 to
739c021
Compare
d4def96 to
1af9588
Compare
3a3c1d3 to
068a3b7
Compare
0c5716f to
afd91c9
Compare
07d197a to
8b9e633
Compare
adc6753 to
becb331
Compare
09513fc to
2b06a08
Compare
2b06a08 to
72ccf34
Compare
dd5ecac to
ac0c0ec
Compare
Follow-up PR to #5569. Add Keyring Support for Auth Storage in Codex CLI as well as a hybrid mode (default to persisting in keychain but fall back to file when unavailable.)
It also refactors out the keyringstore implementation from rmcp-client here to a new keyring-store crate.
There will be a follow-up that picks the right credential mode depending on the config, instead of hardcoding
AuthCredentialsStoreMode::File.